Skip to content

Remove checkDataProviderData and introduce reportMissingDataProviderReturnType #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 2.0.x
Choose a base branch
from
Open

Remove checkDataProviderData and introduce reportMissingDataProviderReturnType #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dbdbc3
Introduce ignoreMissingDataProviderReturnType
VincentLanglet Nov 1, 2025
e876871
reportMissingDataProviderReturnType
VincentLanglet Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions extension.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
parameters:
phpunit:
convertUnionToIntersectionType: true
checkDataProviderData: %featureToggles.bleedingEdge%
reportMissingDataProviderReturnType: false
additionalConstructors:
- PHPUnit\Framework\TestCase::setUp
earlyTerminatingMethodCalls:
Expand All @@ -24,8 +24,8 @@ parameters:

parametersSchema:
phpunit: structure([
convertUnionToIntersectionType: bool()
checkDataProviderData: bool(),
convertUnionToIntersectionType: bool(),
reportMissingDataProviderReturnType: bool(),
])

services:
Expand Down Expand Up @@ -76,4 +76,4 @@ conditionalTags:
PHPStan\PhpDoc\PHPUnit\MockObjectTypeNodeResolverExtension:
phpstan.phpDoc.typeNodeResolverExtension: %phpunit.convertUnionToIntersectionType%
PHPStan\Type\PHPUnit\DataProviderReturnTypeIgnoreExtension:
phpstan.ignoreErrorExtension: %phpunit.checkDataProviderData%
phpstan.ignoreErrorExtension: [%featureToggles.bleedingEdge%, not(%phpunit.reportMissingDataProviderReturnType%)]
2 changes: 1 addition & 1 deletion rules.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ conditionalTags:
phpstan.rules.rule: [%strictRulesInstalled%, %featureToggles.bleedingEdge%]

PHPStan\Rules\PHPUnit\DataProviderDataRule:
phpstan.rules.rule: %phpunit.checkDataProviderData%
phpstan.rules.rule: %featureToggles.bleedingEdge%

services:
-
Expand Down
4 changes: 2 additions & 2 deletions tests/Type/PHPUnit/data/data-provider-iterable-value.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
parameters:
phpunit:
checkDataProviderData: true
featureToggles:
bleedingEdge: true

includes:
- ../../../../extension.neon
Loading