Skip to content

Conversation

@nickschuch
Copy link
Contributor

@nickschuch nickschuch commented Dec 1, 2025

Adds support for PHP 8.5

@jmjoy
Copy link
Member

jmjoy commented Dec 2, 2025

https://github.com/php/php-src/blob/b9e044548b805fc7932f13faf64c6ca967d4b940/Zend/zend_hash.h#L29-L33

In PHP 8.5, HASH_KEY_IS_STRING was changed to enum, and the name of Rust bindgen was also changed.

@nickschuch
Copy link
Contributor Author

nickschuch commented Dec 3, 2025

Sounds like this one is going to be an interesting one :D

Are there any existing examples I can look at where this has happened before that I can use here?

@jmjoy
Copy link
Member

jmjoy commented Dec 3, 2025

I fix it.

@nickschuch nickschuch force-pushed the 8.5 branch 2 times, most recently from 1f0194c to 2a0085b Compare December 3, 2025 09:17
@nickschuch
Copy link
Contributor Author

Oh! Thankyou! Very keen to keep learn more!

@nickschuch
Copy link
Contributor Author

I have reverted a change I pushed for testing

@jmjoy jmjoy merged commit 0408c24 into phper-framework:master Dec 3, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants