Search: Fix "g a" search #1595
Open
Search: Fix "g a" search #1595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllenJB
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who even knew this existed? (type
g,a', then just start typing to search.Esc` exits).This does appear to function differently from the obviously visible search in that appears to search anywhere in the descriptions.
When I changed the keys the search uses, I broke this. This change fixes it to work with the new indexes.
However the styles for this look borked to me, but since I have no idea what it might have supposed to have looked like, I've not touched that.