standard: Simplify array_chunk() #20423
Open
+3
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shrinks the code size from 682 to 601 bytes on x86-64 with GCC 15.2.1. Does not make a difference in performance, at least on my i7-4790. I also tried specialising the pack logic like I did with str_split(), but that is a hit or miss in performance improvement depending on the length. It seems that the instruction cache is become too full, and the fact that add_next_index_zval() and zend_hash_next_index_insert() use the same code internally is beneficial.
Girgias
reviewed
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shrinks the code size from 682 to 601 bytes on x86-64 with GCC 15.2.1. Does not make a difference in performance, at least on my i7-4790. I also tried specialising the pack logic like I did with str_split(), but that is a hit or miss in performance improvement depending on the length. It seems that the instruction cache is become too full, and the fact that add_next_index_zval() and zend_hash_next_index_insert() use the same code internally is beneficial.