Skip to content

zend_builtin_functions.c: Various minor refactorings #20411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

zend_builtin_functions.c: Various minor refactorings #20411

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e148a60
zend_builtin_functions.c: Use RETURN_THROW() for clarity
Girgias Nov 7, 2025
5a748d4
zend_builtin_functions.c: use type uint32_t instead of int
Girgias Nov 7, 2025
ffe540b
zend_builtin_functions.c: use known string when possible
Girgias Nov 7, 2025
788f26a
zend_builtin_functions.c: add const qualifiers
Girgias Nov 7, 2025
35ad722
zend_builtin_functions.c: remove some variable shadowing
Girgias Nov 7, 2025
ac16f5c
zend_builtin_functions.c: refactor is_a_impl() to use early returns
Girgias Nov 7, 2025
c5b081f
zend_builtin_functions.c: use RET{URN|VAL}_BOOL() when possible
Girgias Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Zend/zend_builtin_functions.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1556,7 +1556,7 @@ ZEND_FUNCTION(get_resource_type)
if (resource_type) {
RETURN_STRING(resource_type);
} else {
RETURN_STRING("Unknown");
RETURN_STR(ZSTR_KNOWN(ZEND_STR_UNKNOWN_CAPITALIZED));
Copy link
Member

@ndossche ndossche Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could even use RETURN_INTERNED_STR

}
}
/* }}} */
Expand Down