guess client names from collected stacks (#180)

Author: fbourigault

Collector/Collector.php

@@ -20,13 +20,9 @@
  */
 class Collector extends DataCollector
 {
-    /**
-     * @param array $clients
-     */
-    public function __construct(array $clients)
+    public function __construct()
     {
         $this->data['stacks'] = [];
-        $this->data['clients'] = $clients;
     }
 
     /**
@@ -98,7 +94,9 @@ public function getFailedStacks()
      */
     public function getClients()
     {
-        return $this->data['clients'];
+        return array_unique(array_map(function (Stack $stack) {
+            return $stack->getClient();
+        }, $this->data['stacks']));
     }
 
     /**

DependencyInjection/HttplugExtension.php

@@ -110,12 +110,6 @@ private function configureClients(ContainerBuilder $container, array $config, $p
                 $container->setAlias('httplug.client.default', 'httplug.client.'.$first);
             }
         }
-
-        if ($profiling) {
-            $container->getDefinition('httplug.collector.collector')
-                ->setArguments([$clients])
-            ;
-        }
     }
 
     /**
@@ -452,11 +446,6 @@ function ($id) {
             ])
         ;
 
-        if ($profiling) {
-            $collector = $container->getDefinition('httplug.collector.collector');
-            $collector->replaceArgument(0, array_merge($collector->getArgument(0), [$name]));
-        }
-
         return $serviceId;
     }
 

Tests/Unit/Collector/CollectorTest.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace Http\HttplugBundle\Tests\Unit\Collector;
+
+use Http\HttplugBundle\Collector\Collector;
+use Http\HttplugBundle\Collector\Stack;
+
+class CollectorTest extends \PHPUnit_Framework_TestCase
+{
+    public function testCollectClientNames()
+    {
+        $collector = new Collector();
+
+        $collector->addStack(new Stack('default', 'GET / HTTP/1.1'));
+        $collector->addStack(new Stack('acme', 'GET / HTTP/1.1'));
+        $collector->addStack(new Stack('acme', 'GET / HTTP/1.1'));
+
+        $this->assertEquals(['default', 'acme'], $collector->getClients());
+    }
+}