Merge pull request #179 from fbourigault/display-plugin-fqcn

display plugin fqcn instead of plugin service id

Author: fbourigault

CHANGELOG.md

@@ -1,6 +1,12 @@
 # Change Log
 
-The change log describes what is "Added", "Removed", "Changed" or "Fixed" between each release. 
+The change log describes what is "Added", "Removed", "Changed" or "Fixed" between each release.
+
+## Unreleased
+
+### Changed
+
+- Plugins are now displayed with their FQCN instead of service id.
 
 ## 1.6.0 - 2017-05-22
 

Collector/ProfilePlugin.php

@@ -32,31 +32,24 @@ class ProfilePlugin implements Plugin
      */
     private $formatter;
 
-    /**
-     * @var string
-     */
-    private $pluginName;
-
     /**
      * @param Plugin    $plugin
      * @param Collector $collector
      * @param Formatter $formatter
-     * @param string    $pluginName
      */
-    public function __construct(Plugin $plugin, Collector $collector, Formatter $formatter, $pluginName)
+    public function __construct(Plugin $plugin, Collector $collector, Formatter $formatter)
     {
         $this->plugin = $plugin;
         $this->collector = $collector;
         $this->formatter = $formatter;
-        $this->pluginName = $pluginName;
     }
 
     /**
      * {@inheritdoc}
      */
     public function handleRequest(RequestInterface $request, callable $next, callable $first)
     {
-        $profile = new Profile($this->pluginName);
+        $profile = new Profile(get_class($this->plugin));
 
         $stack = $this->collector->getCurrentStack();
         if (null !== $stack) {

DependencyInjection/HttplugExtension.php

@@ -506,7 +506,6 @@ private function decoratePluginWithProfilePlugin(ContainerBuilder $container, $p
                 new Reference($pluginServiceId.'.debug.inner'),
                 new Reference('httplug.collector.collector'),
                 new Reference('httplug.collector.formatter'),
-                $pluginServiceId,
             ])
             ->setPublic(false);
     }

Tests/Unit/Collector/ProfilePluginTest.php

@@ -141,7 +141,7 @@ public function testProfileIsInitialized()
 
         $this->assertCount(1, $this->currentStack->getProfiles());
         $profile = $this->currentStack->getProfiles()[0];
-        $this->assertEquals('http.plugin.mock', $profile->getPlugin());
+        $this->assertEquals(get_class($this->plugin), $profile->getPlugin());
     }
 
     public function testCollectRequestInformations()