-
Notifications
You must be signed in to change notification settings - Fork 32
K8SPS-567: helm chart generation #1168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
commit: 50c3d2c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
| @@ -0,0 +1,13 @@ | |||
| apiVersion: v2 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having these files here and also in the percona helm repo and having to keep them consistent seems error prone!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree
https://perconadev.atlassian.net/browse/K8SPS-567
DESCRIPTION
This PR adds a generate-helm-chart Makefile target that generates a Helm chart for the PS operator. Specifically
values.yamlandcluster.yaml.The
values.yamlfile is created with the same tool used to generatedeploy/cr.yamlwith all fields specified (cmd/example-gen/cmd/cr-gen). We then post-process the resultingcr.yamlincmd/example-gen/scripts/generate.shto keep the original structure of our Helm chart.The
cluster.yamlfile is created by a new tool,cmd/example-gen/cmd/chart-gen. It is based on https://github.com/elastic/crd-ref-docs, but instead of generating documentation we use it to parse thePerconaServerMySQLtype and feed that data into our go templatecmd/example-gen/cmd/chart-gen/templates/helm.tplto render the chart.In the future it will be easy to modify this new tool to generate a
README.mdfor the Helm chart.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability