Skip to content

Removes dependency of SQLAlchemy _render_string_type base method. Fix #78. #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Removes dependency of SQLAlchemy _render_string_type base method. Fix #78. #79

wants to merge 2 commits into from

Conversation

@fdcastel
Copy link
Contributor

@fdcastel fdcastel commented Jul 3, 2025

No description provided.

This was referenced Jul 3, 2025
Open
Open
Closed
Open
Open
@fdcastel fdcastel marked this pull request as draft July 4, 2025 01:30
@fdcastel
Copy link
Contributor Author

fdcastel commented Jul 4, 2025

The SQLAlchemy authors recommend renaming this method. It's not necessary to use the same name as the base classes.

I'm working on it now.

@fdcastel fdcastel changed the title Updates _render_string_type signature. Fix #78. Removes dependency of SQLAlchemy _render_string_type base method. Fix #78. Jul 4, 2025
@fdcastel fdcastel marked this pull request as ready for review July 4, 2025 01:52
@fdcastel
Copy link
Contributor Author

fdcastel commented Jul 4, 2025

Fixed. The FBTypeCompiler is now more robust against future changes. It was incorrect to rely on internal methods in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fdcastel