Skip to content

fix(Nav): ensure scroll buttons respond to window resize in horizontal nav #12132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(Nav): ensure scroll buttons respond to window resize in horizontal nav #12132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/react-core/src/components/Nav/NavList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { css } from '@patternfly/react-styles';
import { Button } from '../Button';
import AngleLeftIcon from '@patternfly/react-icons/dist/esm/icons/angle-left-icon';
import AngleRightIcon from '@patternfly/react-icons/dist/esm/icons/angle-right-icon';
import { getLanguageDirection, isElementInView } from '../../helpers/util';
import { debounce, getLanguageDirection, isElementInView } from '../../helpers/util';
import { NavContext } from './Nav';
import { PageSidebarContext } from '../Page/PageSidebar';
import { getResizeObserver } from '../../helpers/resizeObserver';
Expand Down Expand Up @@ -38,6 +38,7 @@ class NavList extends Component<NavListProps> {

navList = createRef<HTMLUListElement>();
observer: any = () => {};
handleWindowResize: any;

handleScrollButtons = () => {
const container = this.navList.current;
Expand Down Expand Up @@ -108,11 +109,18 @@ class NavList extends Component<NavListProps> {
componentDidMount() {
this.observer = getResizeObserver(this.navList.current, this.handleScrollButtons, true);
this.direction = getLanguageDirection(this.navList.current);
// Add window resize listener to handle cases where the window resizes but the container doesn't
// This ensures scroll buttons appear/disappear when the window size changes
this.handleWindowResize = debounce(this.handleScrollButtons, 250);
window.addEventListener('resize', this.handleWindowResize);
this.handleScrollButtons();
}

componentWillUnmount() {
this.observer();
if (this.handleWindowResize) {
window.removeEventListener('resize', this.handleWindowResize);
}
}

componentDidUpdate() {
Expand Down
Loading