Skip to content

Remove retired estimates endpoints #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2025
Merged

Remove retired estimates endpoints #99

merged 3 commits into from
Jan 10, 2025

Conversation

@pcothenet
Copy link
Contributor

@pcothenet pcothenet commented Jan 10, 2025 •
edited
Loading

What

  • Remove retired estimates API endpoints:
    • CreateEthereumEstimateRequest
    • CreateShippingEstimateRequest
    • CreateVehicleEstimateRequest

Why

  • Those endpoints were unused and have been fully retired

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the package locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • If endpoints were removed, did you manually remove the corresponding files? (this should be rare)
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@pcothenet pcothenet requested a review from holtbp January 10, 2025 23:28
@pcothenet pcothenet merged commit 59bbaff into main Jan 10, 2025
3 checks passed
@pcothenet pcothenet deleted the pc/2_3 branch January 10, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@holtbp holtbp holtbp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pcothenet @holtbp