feat(payload-builder): add is_resolving flag to signal when payload is being resolved #20106
+86
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s being resolved This adds an `is_resolving` flag to `BasicPayloadJob` and `BuildArguments` that signals to in-progress build tasks when the payload is being resolved. When set, builders can exit the transaction loop early and return whatever payload has been built so far, rather than racing with an empty payload. Changes: - Add `is_resolving: Arc<AtomicBool>` to `BasicPayloadJob` and `BuildArguments` - Set flag to true in `resolve_kind()` method - Check flag in ethereum and optimism payload builder tx loops - Add `is_resolving` to `OpPayloadBuilderCtx` Closes paradigmxyz#15154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an
is_resolvingflag toBasicPayloadJobandBuildArgumentsto signal when the payload is being resolved. This allows in-progress build tasks to exitthe transaction loop early and return a partial payload, rather than racing against an empty payload.
Changes
is_resolving: Arc<AtomicBool>field toBasicPayloadJobis_resolving: Arc<AtomicBool>field toBuildArgumentswith helper methodtrueinresolve_kind()method when resolution startsis_resolvingfield and helper method to `OpPayloadBuilderCtxCloses #15154