API: partial revert of returning read-only EAs from .array/.values #63212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
jbrockmendel
reviewed
Dec 1, 2025
| array._readonly = True | ||
| # TODO decide on read-only https://github.com/pandas-dev/pandas/issues/63099 | ||
| # array = array.view() | ||
| # array._readonly = True |
Member
There was a problem hiding this comment.
is the idea to leave this commented-out indefinitely? or will be cleaned up before merging?
Member
There was a problem hiding this comment.
id prefer to remove but not going to make a stink about it. merge on green(ish)
Member
|
thanks @jorisvandenbossche |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #63099 for context.
This reverts the behaviour change of #61925 partially, to at least ensure that
.arrayand.valuesstill returns the underlying ExtensionArray (if the Series is backed by an extension dtype). Other ways to get a numpy array are still left to return a read-only ndarray for now.