Skip to content

ENH: clarify error message when multiplying bool times Timedelta #63139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+14 −0
Draft

ENH: clarify error message when multiplying bool times Timedelta #63139

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e10d08
raise TypeError in __mul__
natmokval Nov 17, 2025
99e2351
Merge branch 'main' into bug-disallow-multiplication-bool-times-Timed…
natmokval Nov 21, 2025
2e09591
add test, fix typo
natmokval Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pandas/_libs/tslibs/timedeltas.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ from pandas._libs.tslibs.offsets import Day

from pandas._libs.tslibs.util cimport (
is_array,
is_bool_object,
is_float_object,
is_integer_object,
)
Expand Down Expand Up @@ -2311,6 +2312,13 @@ class Timedelta(_Timedelta):
return self.__mul__(item)
return other * self.to_timedelta64()

elif is_bool_object(other):
# GH#62316
raise TypeError(
"Cannot multiply Timedelta by bools. "
"Explicitly cast to integers instead."
Copy link
Member

@jbrockmendel jbrockmendel Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bool and integer singular

Copy link
Contributor Author

@natmokval natmokval Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I've changed it to singular

Copy link
Contributor Author

@natmokval natmokval Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bool and integer singular look better to me too, but I found that in pandas we use both the singular and the plural and sometimes we mix them:

pandas/pandas/core/arrays/timedeltas.py

Lines 481 to 482 in 7bf6660

f"Cannot multiply '{self.dtype}' by bool, explicitly cast to "
"integers instead"

)

return NotImplemented

__rmul__ = __mul__
Expand Down
Loading