Skip to content

TST: df.set_axis() and rename_axis() not failing when allows_duplicate_labels=False #63135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2025
Merged

TST: df.set_axis() and rename_axis() not failing when allows_duplicate_labels=False #63135

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de3df9c
test: add for allow duplicate labels false
kubaszkliniarz Nov 17, 2025
77a0b35
remove redundant comments
kubaszkliniarz Nov 17, 2025
be1e994
add check_flags=False to assert
kubaszkliniarz Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pandas/tests/frame/methods/test_rename_axis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,18 @@ def test_rename_axis_inplace(self, float_frame):
assert no_return is None
tm.assert_frame_equal(result, expected)

def test_rename_axis_with_allows_duplicate_labels_false(self):
# GH#44958
df = DataFrame([[1, 2], [3, 4]], columns=["a", "b"]).set_flags(
allows_duplicate_labels=False
)

result = df.rename_axis("idx", axis=0)
expected = DataFrame(
[[1, 2], [3, 4]], index=Index([0, 1], name="idx"), columns=["a", "b"]
).set_flags(allows_duplicate_labels=False)
Copy link
Contributor

@natmokval natmokval Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment:
I think we can define the expected DataFrame without specifying set_flags. Instead, in the assertion statement we can use check_flags=False.

Copy link
Contributor Author

@kubaszkliniarz kubaszkliniarz Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, looks much cleaner, thank you

tm.assert_frame_equal(result, expected)

def test_rename_axis_raises(self):
# GH#17833
df = DataFrame({"A": [1, 2], "B": [1, 2]})
Expand Down
12 changes: 12 additions & 0 deletions pandas/tests/frame/methods/test_set_axis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,18 @@ def obj(self):
)
return df

def test_set_axis_with_allows_duplicate_labels_false(self):
# GH#44958
df = DataFrame([[1, 2], [3, 4]], columns=["a", "b"]).set_flags(
allows_duplicate_labels=False
)

result = df.set_axis(labels=["x", "y"], axis=0)
expected = DataFrame(
[[1, 2], [3, 4]], index=["x", "y"], columns=["a", "b"]
).set_flags(allows_duplicate_labels=False)
tm.assert_frame_equal(result, expected)


class TestSeriesSetAxis(SharedSetAxisTests):
@pytest.fixture
Expand Down
Loading