CLN: move away from numpy.fix in favor of numpy.trunc #63074
Merged
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all occurrences of
numpy.fixwithnumpy.trunc. This is in response to a currently discussed deprecation ofnumpy.fixas well as performance considerations (nice, but secondary).This change should not change anything in a meaningful way, internally or externally.
It is, however, unclear to me whether this PR should also remove
test_np_fixintest_ufunc.py. I opted to keep it. If desired, I can make this part of the PR. It is worth noting that no correspondingtest_np_truncexists (should it?).pandas/pandas/tests/series/test_ufunc.py
Lines 460 to 467 in 3157d07
Cheers