ENH: resolution inference for array_to_timedelta64 #63018
+167
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements resolution inference for array_to_timedelta64 matching the behavior for the Timedelta scalar. This does not change anything for strings, just np.timedelta64, pytimedelta, and pd.Timedelta objects.
One unintended side effect is that
pd.Series([np.timedelta64(1, "M")])raises instead of casting to "30 days 10:29:06". Need to give that some thought.There is some de-duplication that can be done either before merging or as follow-up.
This fixes some xfails. I'm pretty sure this also addresses some open issues, will need to track those down and add tests.