BUG: Fix DataFrame.from_dict empty row drop #62893
Open
+64
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Thought the fix would be simple but I ran into several edge cases during testing, and so I tried this approach
I appreciate any feedback! |
parthava-adabala
force-pushed
the
fix-from-dict-bug
branch
from
6fce7ea to
64e0ae0
Compare
parthava-adabala
force-pushed
the
fix-from-dict-bug
branch
from
64e0ae0 to
52046f4
Compare
3 tasks
rhshadrach
reviewed
Nov 11, 2025
Member
rhshadrach
left a comment
rhshadrach
left a comment
There was a problem hiding this comment.
Thanks for the PR! Some questions.
|
|
||
| def _from_nested_dict( | ||
| data: Mapping[HashableT, Mapping[HashableT2, T]], | ||
| ) -> collections.defaultdict[HashableT2, dict[HashableT, T]]: |
| if isinstance(s, (dict, ABCSeries)): | ||
| for col in all_cols_list: | ||
| new_data[col][index] = s.get(col, None) | ||
| elif s is None or is_scalar(s): |
Member
There was a problem hiding this comment.
For what input is this case hit?
| new_data[col][index] = v | ||
| if isinstance(s, (dict, ABCSeries)): | ||
| for col in all_cols_list: | ||
| new_data[col][index] = s.get(col, None) |
Member
There was a problem hiding this comment.
For a Series, I believe this will be much slower than the previous implementation. Can you profile this case.
rhshadrach
added
Constructors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.