Skip to content

Conversation

@acrossler
Copy link

Description

  • Replace @doc, @appender, and @substitution decors with inline docstrings for SeriesGroupBy.transform, SeriesGroupBy.describe, SeriesGroupBy.plot, SeriesGroupBy.nlargest, SeriesGroupBy.nsmallest, SeriesGroupBy.corr, SeriesGroupBy.cov, SeriesGroupBy.hist, and SeriesGroupBy.dtype
  • Remove Appender, Substitution, and doc imports

@acrossler acrossler requested a review from rhshadrach as a code owner October 27, 2025 20:12
@rhshadrach
Copy link
Member

rhshadrach commented Oct 27, 2025

Thanks for the PR! This is typically too long to review, I would recommend breaking something like this up into multiple PRs in the future. However once this gets to green, I think we can validate by building docs using main, building docs using this PR, and validating that there are only negligible differences. However the CI builds above need to be passing (you can ignore Pyodide).

@jbrockmendel
Copy link
Member

@acrossler can you address @rhshadrach's comments

@acrossler
Copy link
Author

I will split this into multiple PRs to fix all the issues.

@acrossler acrossler closed this Nov 11, 2025
@acrossler acrossler deleted the groupby-generic branch November 11, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants