Skip to content

STY: Enforce Ruff rule B905 for scripts/validate_unwanted_patterns.py #62860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

STY: Enforce Ruff rule B905 for scripts/validate_unwanted_patterns.py #62860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/validate_unwanted_patterns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,9 @@ def has_wrong_whitespace(first_line: str, second_line: str) -> bool:

tokens: list = list(tokenize.generate_tokens(file_obj.readline))

for first_token, second_token, third_token in zip(tokens, tokens[1:], tokens[2:]):
for first_token, second_token, third_token in zip(
tokens, tokens[1:], tokens[2:], strict=False
Copy link
Member

@jbrockmendel jbrockmendel Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of passing False here, should we update the first three args to tokens[:-2], tokens[1:-1], tokens[2:]?

):
# Checking if we are in a block of concated string
if (
first_token.type == third_token.type == token.STRING
Expand Down
Loading