API: Use lowest possible datetime64 resolution in PeriodIndex.to_timestamp #62732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I don’t think there has been any discussion/consensus on the issue? Same for your other PR this morning. |
Contributor
Author
|
ah i see, i'll make sure to confirm with the members or wait for consensus before working on similar issues next time. Thanks for pointing that out! |
Member
|
Thanks for the PR, but going to close this PR awaiting more discussion in the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates PeriodArray.to_timestamp and PeriodIndex.to_timestamp to return a DatetimeArray with the lowest possible datetime64 resolution based on the period frequency (e.g., yearly periods use datetime64[Y], monthly use datetime64[M], etc.)
Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thankyou !