Fix assert frame equal na dtype false 61473 #62672
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jbrockmendel
reviewed
Nov 5, 2025
| ^^^^^ | ||
| - Bug in :class:`DataFrame` when passing a ``dict`` with a NA scalar and ``columns`` that would always return ``np.nan`` (:issue:`57205`) | ||
| - Bug in :class:`Series` ignoring errors when trying to convert :class:`Series` input data to the given ``dtype`` (:issue:`60728`) | ||
| - Bug in :func:`assert_frame_equal` fails when comparing two DFs containing pd.NA that only differ in dtype and dtype is false (:issue:`61473`) |
Member
There was a problem hiding this comment.
"in dtype and dtype is false" is odd phrasing
DFs -> ```:class:DataFrames````
fails -> failing
jbrockmendel
reviewed
Nov 5, 2025
| Second Series to compare. | ||
| check_dtype : bool, default True | ||
| Whether to check the Series dtype is identical. | ||
| check_dtype : bool, if False |
Member
There was a problem hiding this comment.
check_dtype is already there 2 lines up
Member
There was a problem hiding this comment.
also the default is still True
jbrockmendel
reviewed
Nov 5, 2025
| if not check_dtype and (left.dtype != right.dtype): | ||
| # checks only when check_dtype is False #GH #61473 | ||
| lv, rv = left._values, right._values | ||
| lv = np.asarray(lv, dtype=object) |
Member
There was a problem hiding this comment.
this is going to be really expensive. no other alternatives?
jbrockmendel
reviewed
Nov 5, 2025
| ).rename(columns={"B": "A"}) | ||
| df = DataFrame({"A": range(3), "B": range(3), "C": range(3)}).rename( | ||
| columns={"B": "A"} | ||
| ) |
Member
There was a problem hiding this comment.
these changes look unrelated. please revert
Contributor
Author
|
I am closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.