Zip Strict specification for pandas/core/indexes
#62533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishna-datta
force-pushed
the
addB905Check
branch
from
e14857a to
7b352dc
Compare
mroeschke
requested changes
Oct 10, 2025
pandas/core/indexes/multi.py
Outdated
| new_codes = [] | ||
|
|
||
| for lev, level_codes in zip(self.levels, self.codes): | ||
| for lev, level_codes in zip(self.levels, self.codes, strict=False): |
Member
There was a problem hiding this comment.
What fails when this is True?
Contributor
Author
There was a problem hiding this comment.
None of the tests are failing for any of the cases flagged. I originally set this to False, but after some more digging, and I see the MultiIndex constructor enforces the same length for the levels and codes. Setting these to True
pandas/core/indexes/multi.py
Outdated
|
|
||
| changed = False | ||
| for lev, level_codes in zip(self.levels, self.codes): | ||
| for lev, level_codes in zip(self.levels, self.codes, strict=False): |
Member
There was a problem hiding this comment.
What fails when this is True?
Contributor
Author
There was a problem hiding this comment.
Same as above
pandas/core/indexes/multi.py
Outdated
|
|
||
| retval = [] | ||
| for lev, level_codes in zip(self.levels, self.codes): | ||
| for lev, level_codes in zip(self.levels, self.codes, strict=False): |
Member
There was a problem hiding this comment.
What fails when this is True?
Contributor
Author
There was a problem hiding this comment.
Same as above
mroeschke
approved these changes
Oct 13, 2025
Member
|
Thanks @krishna-datta |
mraabhijit
pushed a commit
to mraabhijit/pandas
that referenced
this pull request
Oct 17, 2025
eicchen
pushed a commit
to eicchen/pandas
that referenced
this pull request
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zip-with-explicit-strictcompliance effort.strict=True