STY: Use strict arg in zip() in pandas/core/reshape
#62483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alvaro-Kothe
suggested changes
Sep 28, 2025
Member
Alvaro-Kothe
left a comment
Alvaro-Kothe
left a comment
There was a problem hiding this comment.
Remove the files you modified from pyproject.toml
Member
|
@jsngn can you merge main and see if you can address the failing tests |
Contributor
Author
|
@jbrockmendel Still failing on errors that are seemingly unrelated to my PR, I'm not sure why |
Member
|
Some of those are unrelated and hopefully will resolve themselves next time you push to the branch. Others look real: |
Contributor
Author
|
Thanks for calling my attention to the issues. PR is passing now, please re-review, thank you! @Alvaro-Kothe @jbrockmendel |
Member
|
@jsngn can you address comments and merge main |
Alvaro-Kothe
reviewed
Nov 4, 2025
Comment on lines
+186
to
+188
| prefix = itertools.islice( | ||
| itertools.cycle([prefix]), data_to_encode.shape[1] | ||
| ) |
Member
There was a problem hiding this comment.
Nice Idea! But I think that itertools.repeat should be preferred.
Comment on lines
+197
to
+199
| prefix_sep = itertools.islice( | ||
| itertools.cycle([prefix_sep]), data_to_encode.shape[1] | ||
| ) |
| # Not all indices can accept None values. | ||
| Index(new_lev, dtype=lev.dtype) if None not in new_lev else new_lev | ||
| for new_lev, lev in zip(new_levs, columns.levels) | ||
| for new_lev, lev in zip(new_levs, columns.levels, strict=False) |
Member
There was a problem hiding this comment.
Just to confirm: was there a failing test because this was True?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests added and passed if fixing a bug or adding a new featurenot applicableAdded type annotations to new arguments/methods/functions.not applicableAdded an entry in the latestnot applicabledoc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.