EHN: handle frozenset in pprint #60828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Only 1 test failing in the cleaning up process. Bet it would go away if we rerun it. |
mroeschke
reviewed
Feb 3, 2025
Member
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
v3.0.0.rst is the appropriate place for the whatsnew note
Contributor
Author
|
@mroeschke whatsnew added |
mroeschke
reviewed
Feb 4, 2025
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Member
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
mroeschke
approved these changes
Feb 5, 2025
Member
|
Thanks again @quangngd |
wjandrea
reviewed
Feb 6, 2025
Contributor
wjandrea
left a comment
wjandrea
left a comment
There was a problem hiding this comment.
Should I open a new PR to fix this?
| assert printing.pprint_thing(MyMapping()) == "{'a': 4, 'b': 4}" | ||
|
|
||
| def test_repr_frozenset(self): | ||
| assert printing.pprint_thing(frozenset([1, 2])) == "frozenset(1, 2)" |
Contributor
There was a problem hiding this comment.
The output should have braces: frozenset({1, 2})
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.