fix: use threading instead of subprocess for Windows provider tests (#639) #1328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Summary
This PR fixes Windows CI failures by refactoring
tests/test_match.pyto use threading instead of subprocess for starting the Flask provider server. The threading approach matches the pattern used inexamples/http/aiohttp_and_flask/test_provider.pyand avoids Windows-specific subprocess issues with stderr/stdout buffering and process handling.Additionally, this re-enables 61 previously disabled compatibility suite tests that were skipped on Windows due to this issue.
Motivation
Issue #639 identified that provider tests fail on Windows because the Flask server started via
subprocess.Popencannot be reached. The subprocess approach has known issues on Windows with:The threading approach eliminates these platform-specific issues and uses
pact._util.find_free_port()for dynamic port allocation as requested by maintainers.Test Plan
🔗 Related issues/PRs