BlueprintSledConfig: add sled subnet
#9416
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunshowers
reviewed
Nov 18, 2025
| Diffable, | ||
| )] | ||
| #[schemars(rename = "Ipv6Subnet")] | ||
| pub struct Ipv6Subnet<const N: u8> { |
Contributor
There was a problem hiding this comment.
Hmm, https://docs.rs/oxnet has Ipv6Net but doesn't use a const generic. Nothing to change here but an interesting inconsistency.
Comment on lines
+136
to
+140
| nic: NetworkInterface { | ||
| id: uuid::Uuid::new_v4(), | ||
| kind: NetworkInterfaceKind::Service { | ||
| id: zone_id.into_untyped_uuid(), | ||
| }, |
Contributor
There was a problem hiding this comment.
ew, we should use typed UUIDs here :(
| .slot_b | ||
| .artifact_hash() | ||
| .map(ArtifactHash), | ||
| subnet: Ipv6Network::from(sled.subnet).into(), |
Contributor
There was a problem hiding this comment.
sighhh ideally we'd use oxnet here too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sled subnets are chosen when the sled is added to the cluster (either by RSS or by the "add sled" process), and do not change for the lifetime of the sled's membership. This PR adds that subnet to
BlueprintSledConfig, removing one of the remaining bits whereBlueprintBuilder::new_based_on()needs information other than the parent blueprint.This PR is staged on top of #9393.