Prettier error messages for unsupported configurations (UX) #1696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorhora
added
enhancement
RIP - libmodsecurity
RIP - libmodsec - missing documentation
3.x
zimmerle
reviewed
Mar 7, 2018
| */ | ||
| | CONFIG_DIR_UNICODE_MAP_FILE | ||
| /* Parser error disabled to avoid breaking default installations with modsecurity.conf-recommended | ||
| driver.error(@0, "SecUnicodeMapFile is not yet supported. utils::string::x2c"); |
Contributor
|
merged. thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale is being explicit on which configurations are currently supported and allowing a smoother transition between v2 to v3, mainly for older or highly modified setups that uses unusual configuration directives.
Also, some unsupported directives that uses CONFIG_VALUE (e.g. SecConnEngine) now allows the user to keep the configuration directive as long as its set to 'Off'.