Skip to content

Conversation

@unatasha8
Copy link
Contributor

Adding a new image for the Device Authorization Flow (content added in separate PR).

Related Issue or Design Document

DOC: OSS 25.4 Launch #9488

Checklist

  • [x ] I have read the contributing guidelines and signed the CLA.
  • [x ] I have referenced an issue containing the design document if my change introduces a new feature.
  • [x ] I have read the security policy.
  • [x ] I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@unatasha8 unatasha8 changed the title chore: added image for device authorization flow docs: Adds article for OAuth2 and OIDC disovery endpoints Oct 20, 2025
@unatasha8 unatasha8 marked this pull request as draft October 20, 2025 21:01
@unatasha8 unatasha8 requested a review from jhickmanit October 20, 2025 21:01
@unatasha8 unatasha8 changed the title docs: Adds article for OAuth2 and OIDC disovery endpoints docs: adds article for OAuth2 and OIDC disovery endpoints Oct 20, 2025
vinckr
vinckr previously requested changes Nov 10, 2025
unatasha8 and others added 2 commits November 10, 2025 12:14
Co-authored-by: Vincent <vincent@ory.sh>
Co-authored-by: Vincent <vincent@ory.sh>
Co-authored-by: Vincent <vincent@ory.sh>
Copy link
Contributor Author

@unatasha8 unatasha8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with review feedback

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there 🚢
Just a few things need to be resolved, then we can merge it imo.

thanks for your patience!

@unatasha8 unatasha8 dismissed vinckr’s stale review November 14, 2025 00:39

This was a simple fix and I made the updates as requested.

Copy link
Contributor

@jhickmanit jhickmanit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@unatasha8 unatasha8 merged commit 51ceab2 into master Nov 14, 2025
9 checks passed
@unatasha8 unatasha8 deleted the una-deviceAuth branch November 14, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants