Skip to content

Conversation

@deepakprabhakara
Copy link
Contributor

@deepakprabhakara deepakprabhakara commented Aug 20, 2025

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

- updated dep
- resolve internal refs in ory resolvers correctly
@deepakprabhakara deepakprabhakara changed the title fix: update configuration schemas chore: added oel configuration schemas Aug 21, 2025
@deepakprabhakara
Copy link
Contributor Author

We still need to figure out a way to automate the version of the spec being read.

@deepakprabhakara deepakprabhakara marked this pull request as ready for review August 21, 2025 10:59
@vinckr vinckr added the upstream Issue is caused by an upstream dependency. label Aug 25, 2025
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it, afaict everything renders well

I found some inconsistencies where the self-hosted config reference is found in the sidebar, but I don't think we need to address it in this PR.
also the OEL sidebar needs some structure down the line, but again doesn't need to be in this PR.

lgtm :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upstream Issue is caused by an upstream dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants