Add a linting workflow

.editorconfig

@@ -0,0 +1,13 @@
+root = true
+
+[*]
+charset = utf-8
+end_of_line = lf
+indent_size = 2
+tab_width = 2
+indent_style = space
+insert_final_newline = true
+trim_trailing_whitespace = true
+
+[*{sh,py}]
+indent_size = 4

.eleventy.js

@@ -19,12 +19,12 @@ const {
 
 const media_filetypes = "jpg,jpeg,JPG,png,gif,svg,avif";
 
-module.exports = function(eleventyConfig) {
+module.exports = function (eleventyConfig) {
     // Configure markdown parser
-    const markdownLib = markdownIt({html: true, typographer: true});
+    const markdownLib = markdownIt({ html: true, typographer: true });
     markdownLib.use(markdownItAnchor);
     markdownLib.use(markdownItAttrs);
-    
+
     eleventyConfig.setLibrary("md", markdownLib);
     eleventyConfig.addPlugin(fortawesomeBrandsPlugin);
     eleventyConfig.addPlugin(syntaxHighlight);
@@ -38,8 +38,8 @@ module.exports = function(eleventyConfig) {
     eleventyConfig.addPassthroughCopy("favicon.png");
     eleventyConfig.addPassthroughCopy("galleries/**/*." + media_filetypes);
     eleventyConfig.addPassthroughCopy("google5458abc1104b04dd.html");
-    eleventyConfig.addPassthroughCopy({"htaccess": ".htaccess"});
-    eleventyConfig.addPassthroughCopy({"content": "."}, {
+    eleventyConfig.addPassthroughCopy({ "htaccess": ".htaccess" });
+    eleventyConfig.addPassthroughCopy({ "content": "." }, {
         filter: ["**/*." + + media_filetypes],
         rename: function (path) {
             return path.replace("content/", "");
@@ -49,7 +49,7 @@ module.exports = function(eleventyConfig) {
     eleventyConfig.addWatchTarget("src/**/*");
     let $collectionApi = null;
 
-    eleventyConfig.addCollection("posts", function(collectionApi) {
+    eleventyConfig.addCollection("posts", function (collectionApi) {
         $collectionApi = collectionApi;
         return collectionApi.getFilteredByGlob("_posts/*.md");
     });
@@ -58,55 +58,55 @@ module.exports = function(eleventyConfig) {
         dynamicPartials: false,
     });
 
-    eleventyConfig.addFilter("cssmin", function(code) {
+    eleventyConfig.addFilter("cssmin", function (code) {
         return new CleanCSS({}).minify(code).styles;
     });
 
-    eleventyConfig.addShortcode("image", async function(src, alt, sizes) {
+    eleventyConfig.addShortcode("image", async function (src, alt, sizes) {
         let metadata = await fetch_image(src);
 
-		let imageAttributes = {
-			alt,
-			sizes,
-			loading: "lazy",
-			decoding: "async",
-		};
+        let imageAttributes = {
+            alt,
+            sizes,
+            loading: "lazy",
+            decoding: "async",
+        };
 
-		// You bet we throw an error on a missing alt (alt="" works okay)
-		return Image.generateHTML(metadata, imageAttributes);
-	});
+        // You bet we throw an error on a missing alt (alt="" works okay)
+        return Image.generateHTML(metadata, imageAttributes);
+    });
 
-    eleventyConfig.addShortcode("img_responsive", async function(src, alt, sizes="100vw, 720, 820, 940, 1140, 1280") {
+    eleventyConfig.addShortcode("img_responsive", async function (src, alt, sizes = "100vw, 720, 820, 940, 1140, 1280") {
         let metadata = await fetch_image(src);
-		let imageAttributes = {
-			alt,
-			sizes,
+        let imageAttributes = {
+            alt,
+            sizes,
             class: "img-responsive",
-			loading: "lazy",
-			decoding: "async",
-		};
+            loading: "lazy",
+            decoding: "async",
+        };
 
-		return Image.generateHTML(metadata, imageAttributes);
+        return Image.generateHTML(metadata, imageAttributes);
     });
 
-    eleventyConfig.addShortcode("image_with_class", async function(src, alt, sizes, class_names) {
+    eleventyConfig.addShortcode("image_with_class", async function (src, alt, sizes, class_names) {
         let metadata = await fetch_image(src);
 
-        if (sizes==undefined || sizes=="_") {
-            sizes="720, 940, 1140, 1280, 2048";
+        if (sizes == undefined || sizes == "_") {
+            sizes = "720, 940, 1140, 1280, 2048";
         }
 
-		let imageAttributes = {
-			alt,
-			sizes,
+        let imageAttributes = {
+            alt,
+            sizes,
             class: class_names,
-			loading: "lazy",
-			decoding: "async",
-		};
+            loading: "lazy",
+            decoding: "async",
+        };
 
-		// You bet we throw an error on a missing alt (alt="" works okay)
-		return Image.generateHTML(metadata, imageAttributes);
-	});
+        // You bet we throw an error on a missing alt (alt="" works okay)
+        return Image.generateHTML(metadata, imageAttributes);
+    });
 
     // Thumbnails
     eleventyConfig.addShortcode("thumbnail_for_post", thumbnails.thumbnail_for_post);
@@ -124,15 +124,15 @@ module.exports = function(eleventyConfig) {
     });
 
     // Liquid filter to convert a date to a string
-    eleventyConfig.addLiquidFilter("to_utc_string", date => date.toUTCString() );
+    eleventyConfig.addLiquidFilter("to_utc_string", date => date.toUTCString());
 
     // Liquid filter for long date string
-    eleventyConfig.addLiquidFilter("date_to_long_string", function(date) {
+    eleventyConfig.addLiquidFilter("date_to_long_string", function (date) {
         return date.toLocaleDateString("en-GB", { weekday: 'long', year: 'numeric', month: 'long', day: 'numeric' });
     });
 
     // Universal filter for jsonify
-    eleventyConfig.addFilter("jsonify", JSON.stringify );
+    eleventyConfig.addFilter("jsonify", JSON.stringify);
 
     eleventyConfig.addFilter("with_explicit_date", items => items.filter(item => "date" in item.data));
 
@@ -142,14 +142,14 @@ module.exports = function(eleventyConfig) {
 
     // Read the menu data from _config.yml and add it to the global data
     eleventyConfig.addGlobalData("menu", () => getDataFromConfigYaml("menu"));
-    eleventyConfig.addGlobalData("site_title",  () => getDataFromConfigYaml("title"));
-    eleventyConfig.addGlobalData("site_tagline",  () => getDataFromConfigYaml("tagline"));
-    eleventyConfig.addGlobalData("production_url",  () => getDataFromConfigYaml("production_url"));
-    eleventyConfig.addGlobalData("JB",  () => getDataFromConfigYaml("JB"));
-    eleventyConfig.addGlobalData("author",  () => getDataFromConfigYaml("author"));
-    eleventyConfig.addGlobalData("now" , () => new Date());
-
-    eleventyConfig.addNunjucksFilter("date", function(date, format) {
+    eleventyConfig.addGlobalData("site_title", () => getDataFromConfigYaml("title"));
+    eleventyConfig.addGlobalData("site_tagline", () => getDataFromConfigYaml("tagline"));
+    eleventyConfig.addGlobalData("production_url", () => getDataFromConfigYaml("production_url"));
+    eleventyConfig.addGlobalData("JB", () => getDataFromConfigYaml("JB"));
+    eleventyConfig.addGlobalData("author", () => getDataFromConfigYaml("author"));
+    eleventyConfig.addGlobalData("now", () => new Date());
+
+    eleventyConfig.addNunjucksFilter("date", function (date, format) {
         return moment(date).format(format);
     });
 

.gitattributes

@@ -1,22 +1,14 @@
-# Auto detect text files and perform LF normalization
-* text=lf
-
-# Custom for Visual Studio
-*.cs     diff=csharp
-*.sln    merge=union
-*.csproj merge=union
-*.vbproj merge=union
-*.fsproj merge=union
-*.dbproj merge=union
-
-# Standard to msysgit
-*.doc	 diff=astextplain
-*.DOC	 diff=astextplain
-*.docx diff=astextplain
-*.DOCX diff=astextplain
-*.dot  diff=astextplain
-*.DOT  diff=astextplain
-*.pdf  diff=astextplain
-*.PDF	 diff=astextplain
-*.rtf	 diff=astextplain
-*.RTF	 diff=astextplain
+# Auto detect text files and perform LF normalization
+* text=lf
+
+# Standard to msysgit
+*.doc	 diff=astextplain
+*.DOC	 diff=astextplain
+*.docx diff=astextplain
+*.DOCX diff=astextplain
+*.dot  diff=astextplain
+*.DOT  diff=astextplain
+*.pdf  diff=astextplain
+*.PDF	 diff=astextplain
+*.rtf	 diff=astextplain
+*.RTF	 diff=astextplain

.github/dependabot.yml

@@ -9,6 +9,7 @@ updates:
     schedule:
       # Check for updates to GitHub Actions every week
       interval: "weekly"
+
   - package-ecosystem: "npm"
     directory: "/"
     versioning-strategy: auto
@@ -18,3 +19,4 @@ updates:
     ignore:
       - dependency-name: "*"
         update-types: ["version-update:semver-patch"]
+

.github/scripts/new_post.sh

@@ -30,11 +30,13 @@ function create_post {
     local file_path="$1"
     echo "Creating post at $file_path"
     touch "$file_path"
-    echo "---" >> "$file_path"
-    echo "title: $POST_TITLE" >> "$file_path"
-    echo "date: $POST_DATE" >> "$file_path"
-    echo "draft: true" >> "$file_path"
-    echo "---" >> "$file_path"
+    (
+        echo "---"
+        echo "title: $POST_TITLE"
+        echo "date: $POST_DATE"
+        echo "draft: true"
+        echo "---"
+    ) >"$file_path"
 }
 
 function main {
@@ -47,5 +49,3 @@ function main {
 }
 
 main
-
-

.github/workflows/on_call_build_site.yaml

@@ -31,14 +31,14 @@ jobs:
           tar -czf _site.tar.gz _site
 
       - name: upload site artifact
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
         with:
           name: _site
           path: _site.tar.gz
           if-no-files-found: error
 
       - name: upload httpd.conf artifact
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
         with:
           name: httpd.conf
           path: _drafts/staging/httpd.conf

.github/workflows/on_call_staging_test.yaml

@@ -8,7 +8,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Fetch site artifact
-        uses: actions/download-artifact@v4.1.8
+        uses: actions/download-artifact@95815c38cf2ff2164869cbab79da8d1f422bc89e # v4.2.1
         with:
           name: _site
       - name: extract site artifact

.github/workflows/on_pr_lint.yaml

@@ -0,0 +1,37 @@
+---
+name: "On PR Lint"
+on:
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  check_dependabot:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout source code
+        uses: actions/checkout@v4
+
+      - name: Check Changes
+        id: changed-env
+        uses: tj-actions/changed-files@ed68ef82c095e0d48ec87eccea555d944a631a4c # v46.0.5
+        with:
+          files: |
+            .github/dependabot.yml
+
+      - if: |
+          steps.changed-env.outputs.any_modified == 'true'
+        run: |
+          npx -y @bugron/validate-dependabot-yaml@latest
+
+  lint_cupcake:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout source code
+        uses: actions/checkout@v4
+
+      - name: Lint Code Base
+        continue-on-error: true
+        uses: oxsecurity/megalinter/flavors/cupcake@v8.5.0
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/on_pr_test.yaml

@@ -11,4 +11,3 @@ jobs:
   staging_test:
     uses: ./.github/workflows/on_call_staging_test.yaml
     needs: build_site
-