Fixed time reset when dialog is open #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if the dialog is open at the event listener, not in startDialogTimer().
Contributor
|
Will likely add this fix in with the future release due to some differences on how this will be handled, but will keep the PR open for now. |
Contributor
|
Can you please check if this got fixed in release 1.0.3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the countdown timer was enabled and the user performed activities while the dialog was open, the countdown timer would reset. This moves the code that checks whether the dialog is open into the event listening function so startSessionTimer() doesn't run (and therefore reset the countdown timer) if the dialog is open. It was not working for me in its previous location.