Skip to content

OS Management Hub: Populate package_classification in package data sources #2459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

OS Management Hub: Populate package_classification in package data sources #2459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d82942
Fix package_classification field in OS Management Hub package data so…
MyoungHaSong Oct 9, 2025
4978fd8
Trigger OCA check - signatures completed
MyoungHaSong Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/integrationtest/os_management_hub_managed_instance_installed_package_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ func TestOsManagementHubManagedInstanceInstalledPackageResource_basic(t *testing
Check: acctest.ComposeAggregateTestCheckFuncWrapper(
resource.TestCheckResourceAttrSet(datasourceName, "managed_instance_id"),
resource.TestCheckResourceAttrSet(datasourceName, "installed_package_collection.#"),
resource.TestCheckResourceAttr(datasourceName, "installed_package_collection.0.items.0.package_classification", "INSTALLED"),
),
},
})
Expand Down
1 change: 1 addition & 0 deletions internal/integrationtest/os_management_hub_managed_instance_updatable_package_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ func TestOsManagementHubManagedInstanceUpdatablePackageResource_basic(t *testing
Check: acctest.ComposeAggregateTestCheckFuncWrapper(
resource.TestCheckResourceAttrSet(datasourceName, "managed_instance_id"),
resource.TestCheckResourceAttrSet(datasourceName, "updatable_package_collection.#"),
resource.TestCheckResourceAttr(datasourceName, "updatable_package_collection.0.items.0.package_classification", "UPDATABLE"),
),
},
})
Expand Down
3 changes: 1 addition & 2 deletions ...ce/os_management_hub/os_management_hub_managed_instance_installed_packages_data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,7 @@ func InstalledPackageSummaryToMap(obj oci_os_management_hub.InstalledPackageSumm
result["name"] = string(*obj.Name)
}

// FIXME
//result["package_classification"] = string(obj.PackageClassification)
result["package_classification"] = string(oci_os_management_hub.PackageSummaryPackageClassificationInstalled)

softwareSources := []interface{}{}
for _, item := range obj.SoftwareSources {
Expand Down
3 changes: 1 addition & 2 deletions ...ce/os_management_hub/os_management_hub_managed_instance_updatable_packages_data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,8 +305,7 @@ func UpdatablePackageSummaryToMap(obj oci_os_management_hub.UpdatablePackageSumm
result["name"] = string(*obj.Name)
}

// FIXME
//result["package_classification"] = string(obj.PackageClassification)
result["package_classification"] = string(oci_os_management_hub.PackageSummaryPackageClassificationUpdatable)

result["related_cves"] = obj.RelatedCves

Expand Down