Skip to content

[AQUA] Fixes loading default params for the AQUA model. #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2025
Merged

[AQUA] Fixes loading default params for the AQUA model. #1243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b8ea8a
Fixes loading default params for the AQUA model.
mrDzurb Aug 9, 2025
5f8037d
Merge branch 'main' into fix_aqua_model_config
mrDzurb Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ads/aqua/common/enums.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ class InferenceContainerTypeFamily(ExtendedEnum):
AQUA_VLLM_LLAMA4_CONTAINER_FAMILY = "odsc-vllm-serving-llama4"
AQUA_TGI_CONTAINER_FAMILY = "odsc-tgi-serving"
AQUA_LLAMA_CPP_CONTAINER_FAMILY = "odsc-llama-cpp-serving"
AQUA_VLLM_OPENAI_CONTAINER_FAMILY = "odsc-vllm-serving-openai"


class CustomInferenceContainerTypeFamily(ExtendedEnum):
Expand Down
5 changes: 1 addition & 4 deletions ads/aqua/modeldeployment/deployment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1161,10 +1161,7 @@ def get_deployment_default_params(
f"{AQUA_DEPLOYMENT_CONTAINER_METADATA_NAME} key is not available in the custom metadata field for model {model_id}."
)

if (
container_type_key
and container_type_key in InferenceContainerTypeFamily.values()
):
if container_type_key:
deployment_config = self.get_deployment_config(model_id)

instance_shape_config = deployment_config.configuration.get(
Expand Down