Skip to content

Conversation

@mrDzurb
Copy link
Member

@mrDzurb mrDzurb commented Feb 2, 2025

Summary

Previously, every enum-like class had metaclass=ExtendedEnumMeta applied directly. This PR introduces a unified ExtendedEnum base class (which itself uses ExtendedEnumMeta) and updates all references to inherit from ExtendedEnum instead.

Benefits

  • Reduces repetition by centralizing the metaclass logic in ExtendedEnum.
  • All enum-like classes now share the same structure and behaviors.
  • Future updates to the metaclass functionality only need to happen in one place, making it easier to maintain and extend.

Changes

  • Added a new ExtendedEnum base class with metaclass=ExtendedEnumMeta.
  • Updated all existing classes using metaclass=ExtendedEnumMeta to inherit from ExtendedEnum instead.
  • Removed direct references to metaclass=ExtendedEnumMeta on child classes.

If any additional specialized behavior is needed, it can be added in the ExtendedEnum class.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 2, 2025
@github-actions
Copy link

github-actions bot commented Feb 2, 2025

📌 Cov diff with main:

Coverage-18%

📌 Overall coverage:

Coverage-19.57%

@github-actions
Copy link

github-actions bot commented Feb 2, 2025

📌 Cov diff with main:

Coverage-71%

📌 Overall coverage:

Coverage-56.72%

Copy link
Member

@VipulMascarenhas VipulMascarenhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@github-actions
Copy link

github-actions bot commented Feb 3, 2025

📌 Cov diff with main:

Coverage-71%

📌 Overall coverage:

Coverage-56.73%

@github-actions
Copy link

github-actions bot commented Feb 4, 2025

📌 Cov diff with main:

Coverage-71%

📌 Overall coverage:

Coverage-56.67%

@mrDzurb mrDzurb merged commit 1932376 into main Feb 4, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants