Skip to content

Conversation

@kumar-shivam-ranjan
Copy link
Contributor

@kumar-shivam-ranjan kumar-shivam-ranjan commented Jan 20, 2025

Description

While registering from object storage, we'll have to ask for task details, which can be one of {Text Generation, Code Synthesis, Text Embedding, Image text to text}. This UI component already exists in the Edit Model page, we'll have to do the same during registering the model via OSS flow.

Task

  • Add a new task parameter for OSS flow during registration of unverified model
  • Add a task parameter input for OSS flow in UI
curl --location 'http://localhost:8888/aqua/model' \
--header 'Content-Type: application/json' \
--data-raw '{
    "model": "BAAI/bge-m3",
    "os_path": "oci://ft-bucket-versioned@ociodscdev/aqua/models/BAAI/bge-m3",
    "inference_container": "odsc-tei-serving",
    "inference_container_uri": "iad.ocir.io/ociodscdev/text-embeddings-inference:1.5.0",
    "task": "feature_extraction"
}'

UI Mocks:

Screenshot 2025-01-21 at 11 16 35 PM Screenshot 2025-01-21 at 11 16 43 PM Screenshot 2025-01-21 at 11 17 21 PM Screenshot 2025-01-21 at 11 18 00 PM

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 20, 2025
@github-actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-19.69%

@github-actions
Copy link

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-19.69%

@github-actions
Copy link

📌 Cov diff with main:

Coverage-100%

📌 Overall coverage:

Coverage-57.25%

@mrDzurb
Copy link
Member

mrDzurb commented Jan 21, 2025

HI @kumar-shivam-ranjan could you add some description for this PR? Which problem we are trying to solve? How the UX will be changed with this enhancement?

@kumar-shivam-ranjan
Copy link
Contributor Author

HI @kumar-shivam-ranjan could you add some description for this PR? Which problem we are trying to solve? How the UX will be changed with this enhancement?

Done

ignore_patterns = input_data.get("ignore_patterns")
freeform_tags = input_data.get("freeform_tags")
defined_tags = input_data.get("defined_tags")
task = input_data.get("task")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use freeform_tags input here for task, right? Then just pop the dict later on and check if the tags contain task.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes correct . closing this PR.
We can use freeform tags for task input for OSS flow based unverified model registration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants