-
Notifications
You must be signed in to change notification settings - Fork 60
Adding task input for model registration in OSS flow #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
HI @kumar-shivam-ranjan could you add some description for this PR? Which problem we are trying to solve? How the UX will be changed with this enhancement? |
Done |
| ignore_patterns = input_data.get("ignore_patterns") | ||
| freeform_tags = input_data.get("freeform_tags") | ||
| defined_tags = input_data.get("defined_tags") | ||
| task = input_data.get("task") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can use freeform_tags input here for task, right? Then just pop the dict later on and check if the tags contain task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes correct . closing this PR.
We can use freeform tags for task input for OSS flow based unverified model registration
Description
While registering from object storage, we'll have to ask for task details, which can be one of {Text Generation, Code Synthesis, Text Embedding, Image text to text}. This UI component already exists in the Edit Model page, we'll have to do the same during registering the model via OSS flow.
Task
UI Mocks: