-
Notifications
You must be signed in to change notification settings - Fork 59
Real-Time What-If Analysis with Model Catalog and Model Deployment Integration #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
de56ae2
added support for What-If Analysis
prasankh e48a966
clean up and fixes
prasankh bf1ec22
added options for reading and model saving
prasankh 9960888
added option to create model deployment for what if analysis
prasankh 91cd4b7
clean up
prasankh 9315bd7
Merge branch 'main' into feature/what-if-analysis
prasankh 93ee156
test fixes
prasankh 3999b33
model serialization fix
prasankh 9799088
Merge branch 'main' into feature/what-if-analysis
prasankh 8b167ab
typo fix, minor improvements
prasankh 4eb3389
doc updated
prasankh 898111e
minor updates and refinements
prasankh 1cdd58e
Merge branch 'main' into feature/what-if-analysis
prasankh c456fbc
Merge branch 'main' into feature/what-if-analysis
ahosler 4a5e552
build fix
prasankh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -341,6 +341,69 @@ spec: | |
| meta: | ||
| description: "Report file generation can be enabled using this flag. Defaults to true." | ||
|
|
||
| what_if_analysis: | ||
| type: dict | ||
| required: false | ||
| schema: | ||
| model_deployment: | ||
| type: dict | ||
| required: false | ||
| meta: "If model_deployment_id is not specified, a new model deployment is created; otherwise, the model is linked to the specified model deployment." | ||
| schema: | ||
| model_deployment_id: | ||
|
||
| type: string | ||
| required: false | ||
| display_name: | ||
| type: string | ||
| required: false | ||
| initial_shape: | ||
| type: string | ||
| required: false | ||
| description: | ||
| type: string | ||
| required: false | ||
| log_group: | ||
| type: string | ||
| required: true | ||
| log_id: | ||
| type: string | ||
| required: true | ||
| auto_scaling: | ||
| type: dict | ||
| required: false | ||
| schema: | ||
| minimum_instance: | ||
| type: integer | ||
| required: true | ||
| maximum_instance: | ||
| type: integer | ||
| required: true | ||
| scale_in_threshold: | ||
| type: integer | ||
| required: true | ||
| scale_out_threshold: | ||
| type: integer | ||
| required: true | ||
| scaling_metric: | ||
| type: string | ||
| required: true | ||
| cool_down_in_seconds: | ||
| type: integer | ||
| required: true | ||
| model_display_name: | ||
| type: string | ||
| required: true | ||
| project_id: | ||
| type: string | ||
| required: false | ||
| meta: "If not provided, The project OCID from config.PROJECT_OCID is used" | ||
| compartment_id: | ||
| type: string | ||
| required: false | ||
| meta: "If not provided, The compartment OCID from config.NB_SESSION_COMPARTMENT_OCID is used." | ||
| meta: | ||
| description: "When enabled, the models are saved to the model catalog. Defaults to false." | ||
|
|
||
| generate_metrics: | ||
| type: boolean | ||
| required: false | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| #!/usr/bin/env python | ||
|
|
||
| # Copyright (c) 2023, 2024 Oracle and/or its affiliates. | ||
| # Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/ | ||
|
|
||
|
|
||
| from .deployment_manager import ModelDeploymentManager |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What triggered this change? If I have an additional data column with a lot of missing data, won't this delete rows from the historical dataset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for flagging. I've reverted this change and tested the new development with it.