Use object storage client for telemetry. #1033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiuosier
requested review from
VipulMascarenhas,
ahosler,
darenr,
mayoor and
mrDzurb
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
|
📌 Cov diff with main: 📌 Overall coverage: |
mrDzurb
previously approved these changes
Jan 6, 2025
|
📌 Cov diff with main: 📌 Overall coverage: |
VipulMascarenhas
approved these changes
Jan 6, 2025
|
📌 Cov diff with main: 📌 Overall coverage: |
mrDzurb
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two potential issue on the telemetry:
set_auth("resource_principal")was called when initializing the client, which may change the authentication method set by the user unintentionally. This PR updates the logic to avoid usingset_auth().requestslibrary, so that the endpoint can be handled by the OCI python SDK.