Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
9cc430b
add ignore validation flag while registering model
VipulMascarenhas Dec 12, 2024
bd4205e
update logging
VipulMascarenhas Dec 12, 2024
9881dcb
Merge branch 'main' into ODSC-65657/ignore_config_validation
VipulMascarenhas Dec 12, 2024
6aaa3ef
improve error message logging
VipulMascarenhas Dec 14, 2024
6b2e4aa
update handler tests
VipulMascarenhas Dec 14, 2024
71269a7
update logging level
VipulMascarenhas Dec 16, 2024
bff4771
Merge branch 'main' into ODSC-65657/ignore_config_validation
VipulMascarenhas Dec 17, 2024
59a042b
log request ids
VipulMascarenhas Jan 3, 2025
a8321a1
update logging for model operations
VipulMascarenhas Jan 3, 2025
fe1eada
Merge branch 'main' into ODSC-65657/ignore_config_validation
VipulMascarenhas Jan 3, 2025
ee8dbf8
update logging for deployment operations
VipulMascarenhas Jan 3, 2025
68f325a
update logging for deployment operations
VipulMascarenhas Jan 4, 2025
86ef7ad
update logging for finetuning operations
VipulMascarenhas Jan 4, 2025
adace88
update logging for finetuning operations
VipulMascarenhas Jan 4, 2025
38e046c
Merge branch 'main' into ODSC-65657/ignore_config_validation
VipulMascarenhas Jan 6, 2025
e3cb8d5
update evaluation validation for create API
VipulMascarenhas Jan 6, 2025
8005294
merge ODSC-65657/ignore_config_validation changes
VipulMascarenhas Jan 6, 2025
b0827e5
update evaluation logging
VipulMascarenhas Jan 6, 2025
ed9504d
update evaluation logging
VipulMascarenhas Jan 6, 2025
fc0caa1
Merge branch 'main' into ODSC-65657/ignore_config_validation
VipulMascarenhas Jan 6, 2025
b83e1e9
Merge branch 'ODSC-65657/ignore_config_validation' of github.com:orac…
VipulMascarenhas Jan 6, 2025
8b603b7
Merge branch 'ODSC-65657/ignore_config_validation' into ODSC-65743/ad…
VipulMascarenhas Jan 6, 2025
ca02f03
update tests
VipulMascarenhas Jan 6, 2025
44d41ce
Merge branch 'main' into ODSC-65657/ignore_config_validation
VipulMascarenhas Jan 6, 2025
d39a1ff
Merge branch 'ODSC-65657/ignore_config_validation' of github.com:orac…
VipulMascarenhas Jan 6, 2025
f4240ce
Merge branch 'ODSC-65657/ignore_config_validation' into ODSC-65743/ad…
VipulMascarenhas Jan 6, 2025
d7ff57d
Merge branch 'main' into ODSC-65657/ignore_config_validation
VipulMascarenhas Jan 8, 2025
fde6c46
Merge branch 'main' into ODSC-65657/ignore_config_validation
VipulMascarenhas Jan 9, 2025
ed4098d
add missing request id
VipulMascarenhas Jan 10, 2025
8db09df
Additional logging statements for AI Quick Actions operations (#1034)
VipulMascarenhas Jan 10, 2025
6b70096
Merge branch 'main' into ODSC-65657/ignore_config_validation
VipulMascarenhas Jan 10, 2025
5621a06
Merge branch 'main' into ODSC-65657/ignore_config_validation
VipulMascarenhas Jan 13, 2025
4cbd7e0
revert to previous validation
VipulMascarenhas Jan 14, 2025
3bc31e5
Resolve merge conflicts
VipulMascarenhas Jan 31, 2025
7616ff2
fix tests after merge
VipulMascarenhas Jan 31, 2025
85a825b
Merge branch 'main' into ODSC-65657/ignore_config_validation
mayoor Feb 1, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ads/aqua/model/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,11 @@
InferenceContainerTypeFamily,
Tags,
)
from ads.aqua.common.errors import AquaRuntimeError, AquaValueError
from ads.aqua.common.errors import (
AquaFileNotFoundError,
AquaRuntimeError,
AquaValueError,
)
from ads.aqua.common.utils import (
LifecycleStatus,
_build_resource_identifier,
Expand Down Expand Up @@ -1206,7 +1210,9 @@ def _validate_safetensor_format(
except Exception as ex:
logger.error(
f"Exception occurred while loading config file from {import_model_details.os_path}"
f"Exception message: {ex}"
)
logger.error(
ex.reason if isinstance(ex, AquaFileNotFoundError) else str(ex)
)
if not import_model_details.ignore_model_artifact_check:
raise AquaRuntimeError(
Expand Down
10 changes: 8 additions & 2 deletions tests/unitary/with_extras/aqua/test_model_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def test_list(self, mock_list):

@parameterized.expand(
[
(None, None, False, None, None, None, None, None),
(None, None, False, None, None, None, None, None, True),
(
"odsc-llm-fine-tuning",
None,
Expand All @@ -142,8 +142,9 @@ def test_list(self, mock_list):
["test.json"],
None,
None,
False,
),
(None, "test.gguf", True, None, ["*.json"], None, None, None),
(None, "test.gguf", True, None, ["*.json"], None, None, None, False),
(
None,
None,
Expand All @@ -153,6 +154,7 @@ def test_list(self, mock_list):
["test.json"],
None,
None,
False,
),
(
None,
Expand All @@ -163,6 +165,7 @@ def test_list(self, mock_list):
None,
{"ftag1": "fvalue1"},
{"dtag1": "dvalue1"},
False,
),
],
)
Expand All @@ -178,6 +181,7 @@ def test_register(
ignore_patterns,
freeform_tags,
defined_tags,
ignore_model_artifact_check,
mock_register,
mock_finish,
):
Expand All @@ -201,6 +205,7 @@ def test_register(
ignore_patterns=ignore_patterns,
freeform_tags=freeform_tags,
defined_tags=defined_tags,
ignore_model_artifact_check=ignore_model_artifact_check,
)
)
result = self.model_handler.post()
Expand All @@ -218,6 +223,7 @@ def test_register(
ignore_patterns=ignore_patterns,
freeform_tags=freeform_tags,
defined_tags=defined_tags,
ignore_model_artifact_check=ignore_model_artifact_check,
)
assert result["id"] == "test_id"
assert result["inference_container"] == "odsc-tgi-serving"
Expand Down
Loading