Skip to content

Commit 2230534

Browse files
committed
code fixes for transfrmation mode check
1 parent f4b4929 commit 2230534

File tree

4 files changed

+13
-11
lines changed

4 files changed

+13
-11
lines changed

ads/feature_store/common/utils/transformation_utils.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,7 @@ def apply_transformation(
5252
# Execute the function under namespace
5353
execution_namespace = {}
5454
exec(transformation_function, execution_namespace)
55-
transformation_function_caller = execution_namespace.get(
56-
transformation.name
57-
)
55+
transformation_function_caller = execution_namespace.get(transformation.name)
5856
transformed_data = None
5957

6058
transformation_kwargs_dict = json.loads(transformation_kwargs)

ads/feature_store/execution_strategy/spark/spark_execution.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,10 @@ def update_feature_definition_features(self, feature_group, target_table):
366366
try:
367367
# Get the output features
368368
output_features = get_features(
369-
self.spark_engine.get_output_columns_from_table_or_dataframe(table_name=target_table), feature_group.id
369+
self.spark_engine.get_output_columns_from_table_or_dataframe(
370+
table_name=target_table
371+
),
372+
feature_group.id,
370373
)
371374
if output_features:
372375
feature_group._with_features(output_features)
@@ -392,7 +395,9 @@ def update_dataset_features(self, dataset, target_table):
392395
try:
393396
# Get the output features
394397
output_features = get_features(
395-
output_columns=self.spark_engine.get_output_columns_from_table_or_dataframe(table_name=target_table),
398+
output_columns=self.spark_engine.get_output_columns_from_table_or_dataframe(
399+
table_name=target_table
400+
),
396401
parent_id=dataset.id,
397402
entity_type=EntityType.DATASET,
398403
)

ads/feature_store/feature_store.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -367,9 +367,7 @@ def create_entity(
367367
"FeatureStore Resource must be created or saved before creating the entity."
368368
)
369369

370-
self.oci_fs_entity = self._build_entity(
371-
name, description, compartment_id
372-
)
370+
self.oci_fs_entity = self._build_entity(name, description, compartment_id)
373371
return self.oci_fs_entity.create()
374372

375373
def delete_entity(self):

ads/feature_store/transformation.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -346,13 +346,14 @@ def create(self, **kwargs) -> "Transformation":
346346
if not self.source_code_function:
347347
raise ValueError("Transformation source code function must be provided.")
348348

349+
if not self.transformation_mode:
350+
raise ValueError("Transformation Mode must be provided.")
351+
349352
if not self.name:
350353
self.name = self._transformation_function_name
351354

352355
if self.name != self._transformation_function_name:
353-
raise ValueError(
354-
"Transformation name and function name must be same."
355-
)
356+
raise ValueError("Transformation name and function name must be same.")
356357

357358
payload = deepcopy(self._spec)
358359
payload.pop("id", None)

0 commit comments

Comments
 (0)