[FSSDK-12080] remove holdouts feature toggle #1110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
next release will contain holdouts
raju-opti
requested review from
Copilot and
junaed-optimizely
and removed request for
Copilot
Copilot finished reviewing on behalf of
raju-opti
November 18, 2025 11:57
There was a problem hiding this comment.
Pull Request Overview
This PR removes the holdouts feature toggle as holdouts will be included in the next release. The changes enable holdout functionality unconditionally throughout the codebase by removing feature toggle checks and associated mock setups.
- Removed all conditional checks for the holdouts feature toggle
- Cleaned up test mocks and imports related to the feature toggle
- Added TypeScript type checking to build scripts for improved type safety
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added tsc --noEmit to build scripts for type checking before bundling |
| lib/feature_toggle.ts | Commented out the holdout toggle function (incomplete cleanup) |
| lib/project_config/project_config.ts | Removed feature toggle import and conditional check in parseHoldoutsConfig |
| lib/project_config/project_config.spec.ts | Removed mock setup, cleaned up imports, and updated test descriptions |
| lib/optimizely/index.tests.js | Removed unused holdout import |
| lib/notification_center/type.ts | Changed holdout type from conditional to direct Holdout | null |
| lib/core/decision_service/index.ts | Removed feature toggle import and made holdout logic unconditional |
| lib/core/decision_service/index.spec.ts | Removed holdout toggle mock setup and cleaned up imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } from 'error_message'; | ||
| import { getMockLogger } from '../tests/mock/mock_logger'; | ||
| import { VariableType } from '../shared_types'; | ||
| import { Mock, afterAll, afterEach, assert, beforeAll, beforeEach, describe, expect, it, vi } from 'vitest'; |
There was a problem hiding this comment.
Unused imports afterAll, beforeAll.
Suggested change
| import { Mock, afterAll, afterEach, assert, beforeAll, beforeEach, describe, expect, it, vi } from 'vitest'; | |
| import { Mock, afterEach, assert, beforeEach, describe, expect, it, vi } from 'vitest'; |
| import testDatafile from '../tests/test_data'; | ||
| import configValidator from '../utils/config_validator'; | ||
| import { FEATURE_VARIABLE_TYPES } from '../utils/enums'; | ||
| import { keyBy, sprintf } from '../utils/fns'; |
There was a problem hiding this comment.
Unused import sprintf.
Suggested change
| import { keyBy, sprintf } from '../utils/fns'; | |
| import { keyBy } from '../utils/fns'; |
junaed-optimizely
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
next release will contain holdouts
Test plan
Issues