[FSSDK-12075] fix odp logging #1108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raju-opti
requested review from
Copilot and
junaed-optimizely
and removed request for
junaed-optimizely
Copilot finished reviewing on behalf of
raju-opti
November 14, 2025 10:43
There was a problem hiding this comment.
Pull Request Overview
This PR refactors ODP (Optimizely Data Platform) error logging to provide better context when the ODP Manager is unavailable.
- Renamed the error constant from
ODP_EVENT_FAILED_ODP_MANAGER_MISSINGto the more genericODP_MANAGER_MISSING - Updated the error message to include the calling method name as a parameter for better diagnostics
- Added comprehensive test coverage for ODP manager missing scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/message/error_message.ts | Renamed constant and updated error message format to accept method name parameter |
| lib/optimizely/index.ts | Updated import and error logging calls in sendOdpEvent and fetchQualifiedSegments to use new constant with method context |
| lib/optimizely/index.spec.ts | Added test cases to verify error logging when ODP Manager is unavailable for both public API methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
junaed-optimizely
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues