Skip to content

Conversation

@camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Nov 8, 2025

  • Use Error level for all error conditions (validation, collision, engine failures)
  • Move verbose success reports to V(1) debug mode
  • Include full diagnostic reports when errors occur

c/c @jianzhangbjz @Xia-Zhao-rh

Copilot AI review requested due to automatic review settings November 8, 2025 23:16
@camilamacedo86 camilamacedo86 requested a review from a team as a code owner November 8, 2025 23:16
@openshift-ci
Copy link

openshift-ci bot commented Nov 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thetechnick for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Nov 8, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 2543dea
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/690fd28bf32d6000072225aa
😎 Deploy Preview https://deploy-preview-2314--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camilamacedo86 camilamacedo86 changed the title 🐛 (fix): boxcutter logging 🐛 fix: improve boxcutter logging levels Nov 8, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the logging strategy for the ClusterExtensionRevision controller by reducing verbosity and providing more actionable error messages. The changes shift detailed reconcile/teardown reports to debug-level logging while elevating validation and collision errors to error-level logging for better visibility.

  • Changed successful reconcile/teardown reports from info-level to debug-level (V(1))
  • Elevated preflight validation errors from info-level to error-level logging
  • Enhanced error logging for reconcile/teardown failures to include report details when available
  • Added phase context to validation and collision error messages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Use Error level for all error conditions (validation, collision, engine failures)
- Move verbose success reports to V(1) debug mode
- Include full diagnostic reports when errors occur
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

❌ Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.28%. Comparing base (b3f85d5) to head (2543dea).

Files with missing lines Patch % Lines
...controllers/clusterextensionrevision_controller.go 53.84% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2314      +/-   ##
==========================================
+ Coverage   71.14%   74.28%   +3.13%     
==========================================
  Files          91       91              
  Lines        7046     7054       +8     
==========================================
+ Hits         5013     5240     +227     
+ Misses       1618     1401     -217     
+ Partials      415      413       -2     
Flag Coverage Δ
e2e 45.83% <0.00%> (-0.11%) ⬇️
experimental-e2e 48.28% <38.46%> (?)
unit 58.53% <38.46%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@camilamacedo86 camilamacedo86 changed the title 🐛 fix: improve boxcutter logging levels 🐛 fix: boxcutter logging levels Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants