-
Notifications
You must be signed in to change notification settings - Fork 68
🐛 fix: boxcutter logging levels #2314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
da24e61 to
423621d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the logging strategy for the ClusterExtensionRevision controller by reducing verbosity and providing more actionable error messages. The changes shift detailed reconcile/teardown reports to debug-level logging while elevating validation and collision errors to error-level logging for better visibility.
- Changed successful reconcile/teardown reports from info-level to debug-level (V(1))
- Elevated preflight validation errors from info-level to error-level logging
- Enhanced error logging for reconcile/teardown failures to include report details when available
- Added phase context to validation and collision error messages
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
internal/operator-controller/controllers/clusterextensionrevision_controller.go
Outdated
Show resolved
Hide resolved
internal/operator-controller/controllers/clusterextensionrevision_controller.go
Outdated
Show resolved
Hide resolved
- Use Error level for all error conditions (validation, collision, engine failures) - Move verbose success reports to V(1) debug mode - Include full diagnostic reports when errors occur
423621d to
2543dea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2314 +/- ##
==========================================
+ Coverage 71.14% 74.28% +3.13%
==========================================
Files 91 91
Lines 7046 7054 +8
==========================================
+ Hits 5013 5240 +227
+ Misses 1618 1401 -217
+ Partials 415 413 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c/c @jianzhangbjz @Xia-Zhao-rh