Tokenize endpoint for LLMs and Visual models #3849
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzegla
reviewed
Dec 8, 2025
| for (size_t i = 0; i < size; ++i) { | ||
| if (attentionMaskPtr[i] == 0 && !pad_to_max_length) { | ||
| break; | ||
| continue; |
Collaborator
There was a problem hiding this comment.
Why do we change that? Do we expect that once we see first 0 in the attention mask any further elements can be different (non-zero)?
Collaborator
Author
There was a problem hiding this comment.
I encountered the issue that with batched data, attention mask was starting with 0 and then the output was correct
mzegla
reviewed
Dec 9, 2025
| ASSERT_EQ(tokenArray.Size(), 25); | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Looks like there is no test for add_special_tokens=true
Collaborator
Author
There was a problem hiding this comment.
This is problematic for vison model used here since special tokens are reserved here for images 🤔 I can implement this method only for lm models.
dkalinowski
reviewed
Dec 10, 2025
dkalinowski
reviewed
Dec 10, 2025
dkalinowski
approved these changes
Dec 10, 2025
mzegla
reviewed
Dec 10, 2025
mzegla
approved these changes
Dec 10, 2025
Co-authored-by: Miłosz Żeglarski <milosz.zeglarski@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
CVS-177520
Adding tokenize endpoint same as for embeddings -https://github.com/openvinotoolkit/model_server/blob/main/demos/embeddings/README.md#usage-of-tokenize-endpoint-release-20254-or-weekly
🧪 Checklist
``