[2025.4.1] Ignore usage statistics (0 tokens) for legacy text generation pipelines #3845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkalinowski
changed the title
dkalinowski
changed the title
mzegla
reviewed
Dec 8, 2025
| } | ||
|
|
||
| // Disabling usage in streaming mode in legacy servable due to the issue with token counting. | ||
| // Fake usage in streaming mode in legacy servable due to the issue with token counting. |
Collaborator
There was a problem hiding this comment.
TODO or FIXME for this?
We definitely don't want to leave such comment here for a longer period.
src/test/llm/llmnode_test.cpp
Outdated
| ASSERT_TRUE(responses.back().find("\"finish_reason\":\"length\"") != std::string::npos); | ||
| } | ||
| // For non-continuous batching servables usage is not supported | ||
| // For non-continuous batching servables usage is faked, always returns 0 |
Collaborator
There was a problem hiding this comment.
I don't know if I would use word fake - maybe fixed would sound better. And I would keep not supported, because that is the actual state of that feature.
dkalinowski
changed the title
dtrawins
approved these changes
Dec 9, 2025
| } | ||
|
|
||
| // Disabling usage in streaming mode in legacy servable due to the issue with token counting. | ||
| // Fake usage in streaming mode in legacy servable due to the issue with token counting. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Fake usage in streaming mode in legacy servable due to the issue with token counting. | |
| // Usage in streaming mode in legacy servable is not supported yet hence we report 0 as a missing metric. |
mzegla
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
Previously there was a fail during last streaming response
Now it streams correctly, but with usage=0 since it is not supported
It enables use of Continue.dev plugin with legacy pipelines