Skip to content

Conversation

@camfairchild
Copy link
Contributor

@camfairchild camfairchild commented Nov 6, 2025

Description

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@github-actions github-actions bot added the hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet label Nov 6, 2025
@camfairchild camfairchild removed the hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet label Nov 6, 2025
@camfairchild camfairchild added the enhancement New feature or request label Nov 6, 2025
@camfairchild
Copy link
Contributor Author

camfairchild commented Nov 8, 2025

This needs to be rebased on #2191

@camfairchild camfairchild marked this pull request as ready for review November 12, 2025 01:35
@camfairchild camfairchild changed the base branch from main to devnet-ready November 12, 2025 02:15
@opentensor opentensor deleted a comment from github-actions bot Nov 12, 2025
@sam0x17 sam0x17 added skip-cargo-audit This PR fails cargo audit but needs to be merged anyway apply-benchmark-patch labels Nov 12, 2025
@sam0x17 sam0x17 added the breaking-change This PR introduces a noteworthy breaking change label Nov 12, 2025
@github-actions
Copy link
Contributor

@opentensor/cerebrum / @opentensor/gyrus / @opentensor/cortex breaking change detected! Please prepare accordingly!

.iter()
.filter(|netuid| !netuid.is_root())
.filter(|netuid| FirstEmissionBlockNumber::<T>::get(*netuid).is_some())
.filter(|netuid| SubtokenEnabled::<T>::get(*netuid))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a better place to do this filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change This PR introduces a noteworthy breaking change enhancement New feature or request skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants