Skip to content

Port src/app/components files from JS to TS #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Port src/app/components files from JS to TS #2799

wants to merge 1 commit into from

Conversation

@OpenStaxClaude
Copy link
Contributor

@OpenStaxClaude OpenStaxClaude commented Nov 25, 2025

Summary

Converts JavaScript files in src/app/components to TypeScript as part of the migration effort tracked in CORE-1386.

Changes

  • loading-placeholder.tsx: Converted loading spinner component to TypeScript, properly typed SVG style attributes
  • router-context.tsx: Added TypeScript types for error boundary state and fail callback function
  • sticky-footer-wrapper.tsx: Added React.ReactNode type for children prop
  • sticky-footer.tsx: Created types for ButtonModel and props, properly typed all component parameters
  • student-form.tsx: Converted to TypeScript, changed tabIndex from string to number

Guidelines Followed

  • Avoided using any type
  • Preferred type over interface
  • Relied on type inference where possible
  • Used inline type definitions for function parameters
  • Kept line lengths under 120 characters
  • Each file ends with a blank line

Related Issue

https://openstax.atlassian.net/browse/CORE-1386

🤖 Generated with Claude Code

@OpenStaxClaude @claude
Port src/app/components files from JS to TS
0a6a691 
- Convert loading-placeholder.js to TypeScript
- Convert router-context.js to TypeScript with proper typing for fail function
- Convert sticky-footer-wrapper.js and sticky-footer.js to TypeScript
- Convert student-form.js to TypeScript
- Add proper type annotations for React props and function parameters
- Update tabIndex to number type in student-form

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OpenStaxClaude