-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS#16171: RNs for BYO OIDC GA #100806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enterprise-4.20
Are you sure you want to change the base?
OSDOCS#16171: RNs for BYO OIDC GA #100806
Conversation
|
🤖 Tue Nov 18 20:29:18 - Prow CI generated the docs preview: |
3563e28 to
799dfaf
Compare
799dfaf to
8651306
Compare
|
/lgtm |
|
@xingxingxia @wewang58 Can you please QE review? This is the preview link, but note that this will not be its final destination. It will be appended to the bottom of whichever z-stream release notes that it goes out with. |
| * OpenShift OAuth server and OpenShift OAuth API server | ||
| * User and group APIs (`user.openshift.io.*`) | ||
| // TODO: Check oauth.openshift.io.TokenReview - it's in the authorization API section, not user and group API | ||
| * OAuth APIs (`oauth.openshift.io.*`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as another PR, place the * like *.oauth.openshift.io instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bergerhoffer This isn't yet updated. Please see the latest supplemental comment #100805 (review) .
8651306 to
ff45078
Compare
|
@xingxingxia Updated per your feedback, can you please take another look? |
ff45078 to
0048e6e
Compare
|
@xingxingxia Updated! |
0048e6e to
febc149
Compare
febc149 to
a6c901e
Compare
|
@xingxingxia I've backed out that incorrect known issue. Does this look okay to you now? |
|
@bergerhoffer: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
Version(s):
4.20 only
Issue:
https://issues.redhat.com/browse/OSDOCS-16171
Link to docs preview:
Temporary link - will update to z-stream once we know which it'll go out in
https://100806--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-20-release-notes.html#ocp-4-20-0-ga_release-notes
QE review:
Additional information:
**Do not merge this at all. This content will get copied into the appropriate z-stream PR and then this will get closed.