Skip to content

Conversation

@fangge1212
Copy link
Contributor

This PR adds support for AMD SEV-SNP on AWS platform.
Upstream PR: kubernetes-sigs/cluster-api-provider-aws#5605
openshift/api PR: openshift/api#2424
machine api operator PR: openshift/machine-api-operator#1420

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 9, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 9, 2025

@fangge1212: This pull request references OCPCLOUD-3072 which is a valid jira issue.

In response to this:

This PR adds support for AMD SEV-SNP on AWS platform.
Upstream PR: kubernetes-sigs/cluster-api-provider-aws#5605
openshift/api PR: openshift/api#2424
machine api operator PR: openshift/machine-api-operator#1420

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from RadekManak and racheljpg October 9, 2025 15:34
@fangge1212 fangge1212 force-pushed the amd_sev_snp branch 7 times, most recently from e68b149 to 2942512 Compare October 10, 2025 06:46
This commit adds support for AMD SEV-SNP instances, so users can
utilize confidential computing technologies on cluster nodes.

Signed-off-by: Fangge Jin <fjin@redhat.com>
Update openshift/api to support confidential computing, specially
AMD SEV-SNP.

Signed-off-by: Fangge Jin <fjin@redhat.com>
@fangge1212
Copy link
Contributor Author

/retest-required

@fangge1212
Copy link
Contributor Author

/retest-required

@RadekManak
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RadekManak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
@sunzhaohua2
Copy link

@yalzhang will help to test this pr, thanks!

@yalzhang
Copy link

/verified by yalzhang

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 27, 2025
@openshift-ci-robot
Copy link
Contributor

@yalzhang: This PR has been marked as verified by yalzhang.

In response to this:

/verified by yalzhang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@fangge1212
Copy link
Contributor Author

/retest-required

1 similar comment
@fangge1212
Copy link
Contributor Author

/retest-required

@sunzhaohua2
Copy link

/retest

@fangge1212
Copy link
Contributor Author

fangge1212 commented Oct 28, 2025

The ci/prow/okd-scos-e2e-aws-ovn failure is not related to the pr.
/override ci/prow/okd-scos-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2025

@fangge1212: fangge1212 unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

In response to this:

The ci/prow/okd-scos-e2e-aws-ovn failure is not related to the pr.
/override ci/okd-scos-e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@damdo
Copy link
Member

damdo commented Oct 28, 2025

@fangge1212 no need to override ci/prow/okd-scos-e2e-aws-ovn as it is optional.

The PR is blocked by ci/prow/e2e-aws-serial at the moment

@damdo
Copy link
Member

damdo commented Oct 28, 2025

ci/prow/e2e-aws-serial is passing but failing on post phase due to timeout.
We need to split it up like we did for serial jobs in other repositories

This job has already been split up, so no need to split it further. The old presubmit was still in there probably because this PR was created before we merged the split PR on o/release. That's fine then.

@damdo
Copy link
Member

damdo commented Oct 28, 2025

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2025

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-aws-serial

In response to this:

/override ci/prow/e2e-aws-serial

Passing but failing on timeout https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_machine-api-provider-aws/141/pull-ci-openshift-machine-api-provider-aws-main-e2e-aws-serial/1977609198833242112

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c0db2c5 and 2 for PR HEAD 98811a6 in total

@damdo
Copy link
Member

damdo commented Oct 28, 2025

/test e2e-aws

2 similar comments
@damdo
Copy link
Member

damdo commented Oct 28, 2025

/test e2e-aws

@fangge1212
Copy link
Contributor Author

/test e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

@fangge1212: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 98811a6 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@fangge1212
Copy link
Contributor Author

/test e2e-aws

@openshift-merge-bot openshift-merge-bot bot merged commit 83e2b4a into openshift:main Oct 29, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants