Skip to content

OCPBUGS-65469: Add ClusterRole to ClusterOperator relatedObjects #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

OCPBUGS-65469: Add ClusterRole to ClusterOperator relatedObjects #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions manifests/0000_26_cloud-controller-manager-operator_12_clusteroperator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,6 @@ status:
- group: ""
name: openshift-cloud-controller-manager-operator
resource: namespaces
- group: rbac.authorization.k8s.io
name: cloud-controller-manager
resource: clusterroles
1 change: 1 addition & 0 deletions pkg/controllers/status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ func (r *ClusterOperatorStatusClient) relatedObjects() []configv1.ObjectReferenc
{Resource: "namespaces", Name: defaultManagementNamespace},
{Group: configv1.GroupName, Resource: "clusteroperators", Name: clusterOperatorName},
{Resource: "namespaces", Name: r.ManagedNamespace},
{Group: "rbac.authorization.k8s.io", Resource: "clusterroles", Name: clusterOperatorName},
Copy link
Member

@wking wking Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a ClusterRole all you need? I'd expect you'd also need a ClusterRoleBinding that attaches that role to a ServiceAccount? And maybe other things?

Copy link
Contributor Author

@RadekManak RadekManak Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looked like a trivial issue. I skimmed the issue a missed that this requires consideration of what to include. I marked the PR as draft and will revisit this next week.

}
}

Expand Down